Officially call json input format JSON Lines?

tsenart / vegeta

HTTP load testing tool and library. It's over 9000!

http://godoc.org/github.com/tsenart/vegeta/lib

MIT License

23.42k stars 1.36k forks source link

Officially call json input format JSON Lines? #682

Open emerikaji opened 7 months ago

emerikaji commented 7 months ago

Hi,

After using the json input format for some load testing, I realized it would be considered valid json Lines input, since it consists of newline-separated JSON objects; For clarity, and to improve the visibility of json Lines as well as its standardization, should the json input format be mentioned as json Lines in the Vegeta documentation? Without the context of the jsonl file format, passing multiple json objects like this rather than something like a list seems a little arbitrary.

tsenart commented 7 months ago

The format was defined without me knowing about JSON lines or NDJSON back then. Were they even a thing at that point?

It's definitely not arbitrary however — it's meant to be streamable, which a JSON array with objects in it isn't.

Happy to review a pull request.