search

tsengvn / typekit

148 stars 27 forks source link

Should be empty application tag and no need for app_name #1

Closed thuytrinh closed 9 years ago

thuytrinh commented 9 years ago

Firstly, thanks for a very convenient library.

We've started evaluating the typekit on one of our product and encountered a conflict:

Error:Execution failed for task ':ourapp:processOurAppBetaManifest'.
> Manifest merger failed : Attribute application@label value=(@string/config_app_name) from (unknown)
    is also present at com.tsengvn:Typekit:1.0.0:13:9 value=(@string/app_name)
    Suggestion: add 'tools:replace="android:label"' to <application> element at AndroidManifest.xml:31:5 to override

Our app has a config_app_name defining app name and this conflicts with the same key defined at the typekit library. While a solution can be to rename config_app_name into app_name as suggested above, I wonder if an alternative is to empty the app tag in AndroidManifest file and no longer use the app_name in the typekit codebase?

We also have library projects and each of them all has an empty app tag like:

<manifest package="com.us.android.ourapp">

    <application />

</manifest>
thuytrinh commented 9 years ago

I've made a PR #2 in case u find the change worthy.

tsengvn commented 9 years ago

thanks @thuytrinh , i merged your code