Closed cary-rowen closed 1 month ago
I wish I can help but I don't know how to code. If you know how to fix this, maybe you can make a pull request for that.
Yes, very likely due to the introduction of https://github.com/nvaccess/nvda/pull/16826.
The say all code has been copied in this add-on. Since it has been modified in https://github.com/nvaccess/nvda/pull/16826, it should probably also be modified similarly in this add-on.
If you know how to make a pull request, you can do so. Do let me know if you need any help in creating pull request.
@lbk2907, I have not investigated in detail the code and I do not plan to do so. I am not a user of this add-on.
I am the author of https://github.com/nvaccess/nvda/pull/16826. @tsengwoody or whoever want to fix this issue can have a look to https://github.com/nvaccess/nvda/pull/16826. If needed, I am available to provide further information to someone wanting to write a fix. But I doubt it will be necessary, since https://github.com/nvaccess/nvda/pull/16826 is not so big.
Fixed: commit 7a72e1
Using NVDA alpha-32997,3f82ab67 (2024.4.0.32997)
Use any of the following shortcut keys:
nvda+a
nvda+shift+a
nvda+b
You will see the following error in the NVDA log:
I'm guessing you monkey patched the sayAll function, This may be due to changes in nvaccess/nvda/#16826 that exposed this issue
I don't think this is an API breaking change in this case, but is still worth bringing to the attention of add-on developers and PR authors.
cc @CyrilleB79 @tsengwoody