Added Instance Method and Value Bindings

[devanflaherty]

Wanted to have a few more options via the directive, so I added some bindings.values to look for to set the options for the Scroll Reveal Instance.

Having these extra options and being able to create a SR Instance from my methods was super helpful, hoping it could help someone else as well.

[tserkov]

There are a couple issues with this pull request:

• You've edited the transpiled distribution file directly. Changes should be made to index.js, and then packaged by running npm run build to update dist/vue-scroll-reveal.js.
• There's no need to break out each option. The entire binding.value is passed to ScrollReveal as options (see index.js#L7).
• Adding a $reveal method to the global Vue object is outside the scope of a pure Vue directive.

Thanks!

[devanflaherty]

Oh okay cool.

Still learning. On Sat, Oct 14, 2017 at 2:25 PM James notifications@github.com wrote:

There are a couple issues with this pull request:

• You've edited the transpiled distribution file directly. Changes should be made to index.js, and then packaged by running npm run build to update dist/vue-scroll-reveal.js.
• There's no need to break out each option. The entire binding.value is passed to ScrollReveal as options (see index.js#L7 https://github.com/tserkov/vue-scroll-reveal/blob/670fa68e12feeeb7ef59932852cdac59109c2bea/index.js#L7 ).
• Adding a $reveal method to the global Vue object is outside the scope of a pure Vue directive.

Thanks!

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/tserkov/vue-scroll-reveal/pull/5#issuecomment-336664648, or mute the thread https://github.com/notifications/unsubscribe-auth/ACX_sY9I8G3NMBw3gZBpQOsU_hr0p5Nzks5ssRi6gaJpZM4P44Wg .