tsg-humlab / shewrote

studying historical early women’s reception: oeuvres, texts, engagements / https://shewrote.rich.ru.nl/
0 stars 0 forks source link

Add UUID id fields for Profession, Genre, Religion and Language #7

Closed vanlummelhuizen closed 10 months ago

vanlummelhuizen commented 11 months ago

Because Profession, Genre and Religion are wwkeywords in the old WomenWriters database and they have UUIDs there, it is probably wise to also use UUIDs in the new database.

See https://repository.womenwriters.rich.ru.nl/v2.1/domain/wwkeywords/autocomplete/profession, https://repository.womenwriters.rich.ru.nl/v2.1/domain/wwkeywords/autocomplete/genre and https://repository.womenwriters.rich.ru.nl/v2.1/domain/wwkeywords/autocomplete/religion.

PS There are more keyword types but they are not (yet) in the schema of the new database:

vanlummelhuizen commented 10 months ago

Also add UUID field to Language. Perhaps more to come.

vanlummelhuizen commented 10 months ago

And perhaps change the field name 'genre' for Genre, 'language' for Language etc. to 'name' for these models so that you have Genre.name instead of Genre.genre etc.

vanlummelhuizen commented 10 months ago

O, and we probably should make the name field unique. Otherwise there could for instance be two Genres 'Novel' which makes no sense. This also goes for Role models by the way.

dennis-bor commented 10 months ago

O, and we probably should make the name field unique. Otherwise there could for instance be two Genres 'Novel' which makes no sense. This also goes for Role models by the way.

It makes sense to also do this for Profession, Religion, and Language.

vanlummelhuizen commented 10 months ago

It makes sense to also do this for Profession, Religion, and Language.

Yup

dennis-bor commented 10 months ago

Done and done.