tsgrissom / PotterPlus

Expansive, lore-friendly Potter configs for NathanWolf's Magic plugin for Minecraft game servers
https://tsgrissom.github.io/PotterPlus/
MIT License
7 stars 4 forks source link

Peruvian Instant Darkness Powder doesn't target source #11

Closed tsgrissom closed 1 week ago

tsgrissom commented 5 years ago

Describe the bug peruvianpowder spell will not target the caster despite target_source: true

To Reproduce Steps to reproduce the behavior:

  1. Do /mgive peruvianpowder
  2. Left-click while holding the wand
  3. Observe how AOE doesn't target the caster if thrown at feet

Expected behavior The AOE attached to the CustomProjectile should apply the PotionEffect to all targets within the radius, including the caster.

Screenshots None.

Additional context Tried shifting around targeting modes to see how I could make it work to no avail.

tsgrissom commented 5 years ago

My theory is that it's a bug with PotionEffectActions which I reported but I'll keep this open until Nathan gets a chance to reply on that thread.

tsgrissom commented 3 years ago

@NathanWolf Still not sure why something like this won't work. Why can't an AOE inside a projectile apply a potion effect to its caster with target_source on? Is there something tied to the projectile? I've fiddled with targeting mode to no avail.

NathanWolf commented 3 years ago

I think it needs target_self: true (target_source vs target_caster vs target_self are all very confusing, sorry!)