search

tsgrp / ActiveWizard

OpenContent Dynamic Forms and Workflow
http://www.tsgrp.com/products/opencontentforms/
4 stars 0 forks source link

Non-required questions showing up in error message #131

Closed mikeblum closed 9 years ago

mikeblum commented 9 years ago

question view error treats non-required question as required:

screenshot 2014-11-26 16 12 11

gsteimer commented 9 years ago

@mikeblum - I don't think you can call #120 as done until this is done too.

mikeblum commented 9 years ago

The error message is a separate module. Page validation works correctly with required and non required questions On Nov 26, 2014 4:16 PM, "George Steimer" notifications@github.com wrote:

@mikeblum https://github.com/mikeblum - I don't think you can call #120 https://github.com/tsgrp/ActiveWizard/issues/120 as done until this is done too.

— Reply to this email directly or view it on GitHub https://github.com/tsgrp/ActiveWizard/issues/131#issuecomment-64711750.

gsteimer commented 9 years ago

That's great, but is still totally confusing for the user. We have to fix these both before calling either one done. On Nov 26, 2014 3:37 PM, "Michael Blum" notifications@github.com wrote:

The error message is a separate module. Page validation works correctly with required and non required questions On Nov 26, 2014 4:16 PM, "George Steimer" notifications@github.com wrote:

@mikeblum https://github.com/mikeblum - I don't think you can call

120

https://github.com/tsgrp/ActiveWizard/issues/120 as done until this is done too.

— Reply to this email directly or view it on GitHub https://github.com/tsgrp/ActiveWizard/issues/131#issuecomment-64711750.

— Reply to this email directly or view it on GitHub https://github.com/tsgrp/ActiveWizard/issues/131#issuecomment-64714185.

danlafeir commented 9 years ago

I believe line number 257 and 279 in pageview.js is where the fix might go. I created a test form called "Non-Required Question Form" which has non required and required questions in it for testing.

mikeblum commented 9 years ago

Revision: 11290 Author: mblum Date: 2014-12-03 15:02:54.600862 fixed bug in active wizard where non-required table questions were showing up as errors when returning to the page. Also fixed bug with copying questions and wrote a unit test.

M /trunk/code/app/modules/wizard/models/questioncollection.js M /trunk/code/test/tests/modules/wizard/wizard/questioncollectionSpec.js M /trunk/code/app/modules/wizard/views/pageview.js