search

tsgrp / HPI

OpenContent Management Suite (OCMS)
http://www.tsgrp.com/products
17 stars 5 forks source link

OCQuery - Alfresco can't search on only TYPE #1273

Closed ghost closed 7 years ago

ghost commented 7 years ago

Previously, Alfresco was able to parse very simple queries and could search on TYPE only. Recent changes to AbstractAlfrescoEmbQueryImpl have removed this functionality, and it is causing issues across HPI. The following query will now fail when it was previously working:

screen shot 2016-12-22 at 10 33 32 am
gsteimer commented 7 years ago

Related to #1271. If that issue is fixed by adding some sort of select statement, we should test that those changes can be reverted once this is fixed in OC.

mikeblum commented 7 years ago

We'll want to maintain the functionality of searching on multiple types:

(QUERY AND (TYPE:A Or TYPE:B OR TYPE:C))

We can add a case to AlfrescoEmbQueryImpl where the query is just a type, not a query + type.

ZachGerth commented 7 years ago

The issue is just related to empty parentheses at the beginning of the query where we generate Alfresco queries. If we simply make sure to not add this empty pair of parentheses, we avoid the issue entirely.

mikeblum commented 7 years ago

yep - sounds reasonable. I blindly put a starting ( and a closing ) before the TYPE clause to avoid a leaky expression.

ZachGerth commented 7 years ago

Around the types is fine, it's before then that we have the issue

On Dec 22, 2016 11:03 AM, "Michael Blum" notifications@github.com wrote:

yep - sounds reasonable. I blindly put a starting ( and a closing ) before the TYPE clause to avoid a leaky expression.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/tsgrp/HPI/issues/1273#issuecomment-268843761, or mute the thread https://github.com/notifications/unsubscribe-auth/ANh5rNmNyPspW31t4yZzutrpGPsSbS7Fks5rKq1ugaJpZM4LUJtE .

rosenoam commented 7 years ago

OC Revision #15715