tsgrp / HPI

OpenContent Management Suite (OCMS)
http://www.tsgrp.com/products
17 stars 5 forks source link

Alfresco's addRendition Incorrectly Implements Interface with Different Logic for Return Value #2332

Closed abrown45 closed 2 years ago

abrown45 commented 4 years ago

Issue

In other backends, the return value is the list of childIds that had the relation applied to them associating them to the parentId of the relation. In alfresco, that list only contains the parent id. This is causing branching behavior in ACA where those Ids are added to a success or error list to be further processed. AlfrescoEmbContentImpl#doAddRelation should be updated to match other logic and places that use the addRealtion endpoint should be updated/notified of that change to confirm their behavior remains as expected. Thankfully, to my knowledge, all the many places this method is used, the code that calls this function does not perform any logic on the returned object other than check if any object to throw an error is false. Most places do not pass this object outside of OC but in the instances it is ACA does not perform any logic on this value. I checked all 25 instances. This only affects the implementation of #2320.

abrown45 commented 3 years ago

updating stubs to void returns and throws an error instead of returning an empty list

gsteimer commented 2 years ago

Moved to Jira: https://alfresco.atlassian.net/browse/SEP-37