OpenOverlay: Failure to Apply Overlay to A3 Sized Documents (Portrait or Landscape)

[mwojno-tsg]

Overview

• OpenOverlay supports A3 pages by default, however there is an issue with the code and it fails to apply an overlay to any A3 sized pages. This causes the code to fallback to the Letter size, which won't look correct.

Reproduce

• Upload a A3 sized document in portrait or landscape. View the document and watch the overlay not be applied. The logs will tell us that there was an error finding the page size.

Proposed Solution

if((pageWidth == letter.getHeight()) && (pageHeight == letter.getWidth())) {return "letter";}
else if((pageWidth == legal.getHeight()) && (pageHeight == legal.getWidth())) {return "legal";}
else if((pageWidth == tabloid.getHeight()) && (pageHeight == tabloid.getWidth())) {return "tabloid";}
else if((pageWidth == executive.getHeight()) && (pageHeight == executive.getWidth())) {return "executive";}
else if((**Math.ceil**(pageWidth) == Math.round(a3.getHeight())) && (**Math.ceil**(pageHeight) == Math.round(a3.getWidth()))) {return "a3";}
else if((Math.round(pageWidth) == Math.round(a4.getHeight())) && (Math.round(pageHeight) == Math.round(a4.getWidth()))) {return "a4";}

• The above code is how we determine the page sizes. For A4 and A3, rounding needs to happen because these pages could have widths and heights that aren't exact.
• The height matching above is correct, but the width is off. What I changed, is in stars **. I propose that we do a ceiling round. For example, the pageHeight I was testing with was 1190.4 and it is being compared to 1191. You can see with regular rounding this would not pass. That was the issue that was happening.

[mwojno-tsg]

Remember to take a look and update documentation, if necessary.

[mwojno-tsg]

This issue was closed following the solution described above. For a3 and a4, I changed round to ceil because of a rounding issue that was skipping the a3 page size.

OpenOverlay commit: 247 OC commit: 26809

CR: rsaladrigas, ballen