tsgrp / HPI

OpenContent Management Suite (OCMS)
http://www.tsgrp.com/products
17 stars 5 forks source link

Inconsistent overriding of beans in client amp #2468

Closed katiebrill closed 2 years ago

katiebrill commented 2 years ago

I was having trouble with overriding some logic in OC in the client amp. I was trying to override some OC beans in the opencontent-extension-override-module-context.xml in the client amp. It turns out that this causes inconsistent behavior of whether the bean in the client amp or the bean in OC will be loaded first and which class will therefore end up being used.

This is because of the naming of the file. Alfresco scans all resources for files ending in context.xml and loads those first... in a random order.

SO what I needed to do was rename this file to opencontent-extension-override-module-ctx.xml in the client amp and update our module-context.xml in the policy-and-procedure-alf7 to load the resource with the new filename. That way our override file wont get scanned in as a part of that initial load of resources and we can instead guarantee that it will override the module-context.xml file.

I do not expect this change to affect current PaaS clients as any clients with the file still named as opencontent-extension-override-module-context.xml in the client amp will still get their file loaded in at the beginning as it always has. They will continue to see inconsistent behavior of this file loading until they rename the file in the client amp to opencontent-extension-override-module-ctx.xml

katiebrill commented 2 years ago

OC commit 27079

Fixed for PNP alf 6 and 7.

Note that this will be fixed at the trunk level as a part of 3.5 by @Kovacinski

katiebrill commented 2 years ago

Opened new issue to get this back to trunk so closing this one since it is completed for 3.4.4.2