tsgrp / HPI

OpenContent Management Suite (OCMS)
http://www.tsgrp.com/products
17 stars 5 forks source link

Consistent "Toss Across" control in the admin #371

Open gsteimer opened 10 years ago

gsteimer commented 10 years ago

The HPI admin has too many inconsistent toss across controls.

@joehof @mbowen000 - I believe there's an example of how this should look in the future with the new form config. Can you add a screenshot?

Some examples of the current controls below:

image

image

The left side of this one extends beyond the page: image

gsteimer commented 10 years ago

Here's another one from the View All Documents action config:

image

mikeblum commented 10 years ago

Im taking what we have in form config and making a featuer branch to see if we can generalise this into a plugin we can use across the admin and in different modules.

mikeblum commented 10 years ago

Got the technical side down. here's what it looks like - not pretty but it works: screenshot from 2014-08-19 14 59 36 @mbowen000

mikeblum commented 10 years ago

wiki article: https://github.com/tsgrp/hpi/wiki/Toss-Across

mikeblum commented 10 years ago

Places to update:

gsteimer commented 10 years ago

@mikeblum - I unassigned you since you're busy with a client project. Do you and @mbowen000 think this is in a good enough place where a new hire could start implementing the (however ugly for now) new toss across everywhere in the admin?

mikeblum commented 10 years ago

I think so. It's been pretty tested at this point. But I expect some aspects to get a little weird. On Sep 26, 2014 10:22 AM, "George Steimer" notifications@github.com wrote:

@mikeblum https://github.com/mikeblum - I unassigned you since you're busy with a client project. Do you and @mbowen000 https://github.com/mbowen000 think this is in a good enough place where a new hire could start implementing the (however ugly for now) new toss across everywhere in the admin?

— Reply to this email directly or view it on GitHub https://github.com/tsgrp/hpi/issues/371#issuecomment-56976249.

grahamsinger commented 9 years ago

I have put in the toss across upgrades that I have finished so far (with revisions 11178, 11180, 11181)

There are other places in the admin that still haven't been upgraded to this new plug in (thus, I will leave this open). I am sure of a couple of actions that still have the previous toss-across in them, and I'd be willing to bet that there are a handful more. It seems worth discussing which of these have the highest importance before proceeding.

It's also worth noting that there are varying degrees of "difficulty" associated with making these upgrades as the code that fed the previous toss across implementation is wildly different across the different implementations (i.e. some already used Backbone, but most used ko or kb or some crazy mix of both).

gsteimer commented 9 years ago

@grahamsinger - on Edge1 and Edge2, all of the saved search dashlets have the type attributes toss across looking like this:

image

Is that an easy fix?

ghost commented 9 years ago

I have already fixed that alignment locally and will be committing it soon.

grahamsinger commented 9 years ago

@b-k-white thanks!

mikeblum commented 9 years ago

In search config for table view we still have the old toss across.

Search > Table View > Display Attibutes

katiebrill commented 5 years ago

Found additional inconsistencies with toss acrosses in HPI Admin. Looks like many now look like: tossacross Examples include SendEmail and DownloadCollectionAsDocument Actions.

While others look more like the images mentioned earlier in this issue (not having any orange boxes). Examples include CreateFolder and StartWorkFlow.