search

tsgrp / HPI

OpenContent Management Suite (OCMS)
http://www.tsgrp.com/products
17 stars 5 forks source link

Advanced Search - Form displays some fields as textbox rather than configured control #930

Open gsteimer opened 8 years ago

gsteimer commented 8 years ago

This could be a configuration problem, but if it is, I'm not seeing it. On edge2's Contract Management trac, I'm seeing this:

Contract Document - a few attributes configured and displaying in Attribute Search image

Contract Document - Advanced Search only displays Name image

Shouldn't the attributes in Advanced Search mirror Attribute Search?

gsteimer commented 8 years ago

Quick update - in the console, I'm seeing this when I switch to Contract Document:

image

gsteimer commented 8 years ago

Update - from talking to @peterkk, I think this has something to do with proximity dates not being supported in the advanced search form. Updating the title here - feel free to change it again if this turns out to not be the case.

gsteimer commented 8 years ago

Looking at this again - we should test Complex search with other form fields too. The second field in the form is a Dropdown, which is rarely used. I could also see Dropdown being an issue in Advanced search as well (maybe only Autocomplete was implemented?). I've seen textbox, date, and autocomplete working. we should also test:

dgrumieaux commented 8 years ago

Waiting on code review according to @grahamsinger

grahamsinger commented 8 years ago

Yeah, this is ready to go in, but in fixing this bug, @alieblich and I discovered a place in the advanced search code where the code could be improved in regards to how we are repopulating the models and views on a refresh of a page with search results/parameters.

Because of this I thought we would discuss the best way to improve this part of the code going forward before we go ahead with the other unimplemented controls listed above.

ZachGerth commented 8 years ago

Added Proximity Date and Dropdown controls with commit # 14042. CR - grahamsinger

ZachGerth commented 8 years ago

Right now Checkbox, Datetime, Radio, and Textarea default to the Textbox control, and so don't really fit their control at all - these still need to be implemented for advanced search.