search

tsgrp / HPI

OpenContent Management Suite (OCMS)
http://www.tsgrp.com/products
17 stars 5 forks source link

Ability to tag an action as "noContext" #94

Closed gsteimer closed 10 years ago

gsteimer commented 10 years ago

We need some way to tag certain actions as having the ability to execute without a context object. Something like this in the action config would work:

Whatever we call the property, null and false should default to the action requiring a context object.

Once this is in place, the list of available actions in the ApplicationConfig section of the admin should only display noContext actions:

image

Currently, this view displays all non-group actions, most of which will not work properly in the header.

As of Dec 2013, the following actions should be noContext actions:

  • action-createWizardForm
  • action-createFolder-noContext
mikeblum commented 10 years ago

Revision: 8501 Author: mblum Date: Friday, January 10, 2014 5:03:27 PM Message:

fix for https://github.com/tsgrp/hpi/issues/94

Modified : /trunk/code/app/modules/hpiadmin/actionconfig/hpiactionconfig.js

gsteimer commented 10 years ago

Were the actions I mentioned in the original post marked as "noContext"? If not, we need to do that and test it before closing this issue. On Jan 10, 2014 5:05 PM, "Michael Blum" notifications@github.com wrote:

Closed #94 https://github.com/tsgrp/hpi/issues/94.

— Reply to this email directly or view it on GitHubhttps://github.com/tsgrp/hpi/issues/94 .

mikeblum commented 10 years ago

the actions are marked as noContext in Spring. working on a fix now to pass in defaults to any action, regardless o f a -noContext flag (or any other -flag for that matter)

mikeblum commented 10 years ago

Revision: 8504 Author: mblum Date: Monday, January 13, 2014 12:14:05 PM Message:

fix for defaults not populating when selected a -noContext action: https://github.com/tsgrp/hpi/issues/94 - unit tested. CR'd dgrumieaux

Modified : /trunk/code/app/modules/actions/actionmodules.js Modified : /trunk/code/app/modules/hpiadmin/actionconfig/hpiactionconfig.js Added : /trunk/code/test/tests/actions/actionModulesSpec.js