search

tsgrp / OpenAnnotate

TSG's Browser-based Annotation Tool
8 stars 4 forks source link

OA Image Viewing - Rotate buttons show up but do not function #442

Open parkertdrake opened 5 years ago

parkertdrake commented 5 years ago

This issue was caused by OA revision #5094 (CR - Kim, Marc)

When looking at images in OA,, the rotate buttons show up in the toolbar but do not function. In OA commit #5094 the rotate actions were edited to no longer be pdf only actions. They are now not being deregistered for non-pdf documents in actionregistry.js, so they do show up in OpenViewer for images. However these actions are not yet implemented for images.

The commit was allowed to go through because another team at TSG already has the implementation for image rotation in their pipeline.

image_rotate

parkertdrake commented 5 years ago

Partially fixed with revision #5499, rotate buttons and fitToHeight and fitToWidth buttons should now work in OpenViewer. They'll still break in other modes so this issue will stay open for now.