search

tsgrp / OpenAnnotate

TSG's Browser-based Annotation Tool
8 stars 4 forks source link

Redaction darkens with each click #778

Open katiebrill opened 4 years ago

katiebrill commented 4 years ago

issue3

If you use the redact feature in search, each time you click the redact icon the redaction on the document gets darker and darker. This does not affect the redaction functionality and is just a cosmetic fix (i.e. currently you can click redact only one time and it will show as an opaque gray box, but once you save it will darken it to black). This issue is just to point out the point that the current darken behavior is misleading and should be resolved.

m-brouillette commented 4 years ago

The root cause of this is that each click is drawing another redaction annotation in the same place. So a potential non-UI impact of this is on performance, if the server is attempting to make multiple redundant redaction. Worse still if one of the redactions has a "Reason" and the following ones done, the resulting redaction could be missing a redaction.

In general we should 'flag' a search result as having been redacted once the first redaction is drawn. Wouldn't prevent similar searches from overlapping, but hopefully there it's more clear to the user what is happening.