Missing All Annotations Intermittently With "parentEventView" Null - Githubissues

tsgrp / OpenAnnotate

TSG's Browser-based Annotation Tool

8 stars 4 forks source link

Missing All Annotations Intermittently With "parentEventView" Null #853

Closed mwojno-tsg closed 3 years ago

mwojno-tsg commented 3 years ago

Overview

There is a timing issue on large documents that results in no annotations showing up. This is caused by parentEventView being null and the code trying to access a property from the null object.

Steps to Reproduce

Load a large document on edge. Reload the pages a couple times until you see no annotations and the save button is disabled, signifying some fatal javascript issue occurred.

Solution

Bringing this back from @jlittle-tsg's commit on a customer's branch, to add a check that the parentEventView is defined before checking if raphael surfaces are ready. This will prevent the console error and not fatally fail loading the annotations.

mwojno-tsg commented 3 years ago

This issue is closed with the following commit to AEV: 7171. The above solution was followed.

CR: dvora, jlittle