tsgrp / OpenAnnotate

TSG's Browser-based Annotation Tool
8 stars 4 forks source link

Warning Message for Offline Review Check-in when External Check-in is Available #857

Closed engerernoah closed 3 years ago

engerernoah commented 3 years ago

Now that external check in is available and split out of the oflline checkin we need to add some context to the upload modals to help user's determine if they are using the correct action. If a user accidentally uses the Checkin Annotated PDF action when they meant to use the new external checkin action they will remove any online annotations they added since the download. Additionally External annotations will not be brought in when using the Checkin Annotated PDF we need to provide some context here for users in the form of a warning message on the upload.

These warning messages should only show on the modal if the external check in action is available to users. If this action is not configured the checkin there is no confusion between external checkin and the normal checkin annotated pdf since external is not available.

engerernoah commented 3 years ago

REVISION: #7207 ADDING CONTEXT/WARNING MESSAGE TO UPLOAD ACTION MODALS - Adding a message for our Checkin Annotated PDF action to provide users with some more context and a warning to avoid using this action for external uploads as it may erase their online data. Updating the preexisting message for the external upload action and making styling consistent for both of them, also minor styling tweaks to other areas of the upload modal. These messages only show up if the external upload action is configured. Added new function to the actionRegistry that returns true/false if an action is registered.

CR: dvora, jlittle, jharkins, mbrouillette