tsgrp / OpenAnnotate

TSG's Browser-based Annotation Tool
8 stars 4 forks source link

Annotation deletion does not work sometimes when collaboration mode is off #864

Open dhruvvora94 opened 3 years ago

dhruvvora94 commented 3 years ago

If collaboration mode is off - then deletion of annotations does not always work correctly.

This is probably because of a timing issue where the getAnnotations call is made before the delete call is completed.

This also results in multiple xfdf documents being created in the repo.

delete-annotations

m-brouillette commented 3 years ago

@dhruvvora94 - Could we apply a similar fix to what we did for the save calls that were overrunning each other ?

dhruvvora94 commented 3 years ago

We can't remove the get calls entirely which is what we did for collaboration mode. We can however add in some checks to make sure that it waits for the delete call to complete successfully.