search

tsgrp / OpenAnnotate

TSG's Browser-based Annotation Tool
8 stars 4 forks source link

Sidebar Modules' Heights can be off #87

Open m-brouillette opened 9 years ago

m-brouillette commented 9 years ago

Depending on the number of modules per sidebar and the current resolution some of the sidebar modules' height calculations are off for modules with internally scrollable content. The two prime we see issues are circled in the image below: sidebaroffsets

Fixing this issue would also be a good chance for us to use Marionette to simplify these modules now that they're all Marionette views. We could add a super-view-class, that the various sidebar modules would inherit, which would handle the resizing of the individual sidebar modules rather than each one handling things in its own way.

m-brouillette commented 6 years ago

Reminder that this is a problem. It is particularly jarring for the Thumbnails tab, which has no bottom border.

image