search

tsgrp / OpenAnnotate

TSG's Browser-based Annotation Tool
8 stars 4 forks source link

User can click on the reply button of an annotation even when they dont have permissions #896

Closed dhruvvora94 closed 3 years ago

dhruvvora94 commented 3 years ago

When there is an annotation that has a reply - users who do not have permission to annotate a document are still able to click on the reply button.

newmanju commented 3 years ago

Resolved with SVN commit 7321:

This was caused by OA not taking into account if the application was in read only mode or not when determining if an annotation should be reply-able. The fix was adding the condition check of not being in read only mode for an annotation to be reply-able.

CR: dvora, jlittle