search

tsgrp / OpenAnnotate

TSG's Browser-based Annotation Tool
8 stars 4 forks source link

Most toolbar buttons no longer working in IE 11 #902

Closed jharkins2 closed 3 years ago

jharkins2 commented 3 years ago

Most buttons no longer function in IE 11, I'm guessing due to the style refresh:

ie_button_issue

abrown45 commented 3 years ago

This only effects pure action buttons. Any dropdown, collaboration button, help, etc are working as expected. Defaulted value are correct, click event does not seem to be processed.

abrown45 commented 3 years ago

Click event is tied to the ripple. Since action buttons by themselves are button elements, IE does not pass the click event to the children as other browsers. The solution would be to update the button to be a div instead and modify the styling around it or listen to the button instead of the ripple. Reconfirming the buttons work, the active state works, mousedown styling and mouseover styling work appropriately

abrown45 commented 3 years ago

Commit #7345: STYLE REFRESH BUG FIX: IE BUTTONS NOT CLICKABLE - updating action buttons to be div elements due to an issue in IE. IE does not propagate click events from a child element of a button up to the parent button so to counter this the elements are converted to divs and button behavior styling is added as a class. If support for IE is discontinued, these divs should be replaced back to buttons. GH: https://github.com/tsgrp/OpenAnnotate/issues/902

CR: mbrouillette, dvora