tsgrp / OpenAnnotate

TSG's Browser-based Annotation Tool
8 stars 4 forks source link

OC Side of Prune PDF Adds ".pdf" to End of Filename Even if Another Extension is Present #912

Closed newmanju closed 3 years ago

newmanju commented 3 years ago

OC is hard-coded to add in the ".pdf" extension to a pruned document's filename if ".pdf" is not already present, even if a different extension is present. This causes weird filenames like "filename.txt-2.0-(1,3).pdf". We can be smarter with how we do this, either by parsing out the existing file extension or by passing a boolean parameter for if ".pdf" should be added (or both).

newmanju commented 3 years ago

Closed with SVN Revision 7422:

Adjust split and prune so that the produced files use more similar naming conventions and have the correct extension. Achieved this by removing the extension from the filename in AEV. For split, also made sure that the right parameters were passed to OC to ensure the ".pdf" extension is appended.

CR: jnewman, jharkins