search

tsgrp / OpenAnnotate

TSG's Browser-based Annotation Tool
8 stars 4 forks source link

Number.isNan is Not Supported in IE11 and is Used in Quill Mention #921

Closed newmanju closed 3 years ago

newmanju commented 3 years ago

The Quill Mention module used the Number.isNan function which is not supported in IE11. This issue does not break mention functionality, but mention dropdown options will not be highlighted on mouse over. This also means you cannot mouse over an option and press enter to select it. You can still click on the options and that works fine.

The issue is found in src/main/webapp/js/lib/quill-mention/quill.mention.csj.js on line 639.

The solution is to edit the above file to use IE11 compatible way to check if a number is nan on that line

newmanju commented 3 years ago

Closed with AEV SVN revision 7442:

REPLY AND MENTION NOTIFICATIONS: This commit introduces a new feature: Mentions! Mentions allow you to use the @ symbol to mention another user in your annotation comment. A quill module called Quill Mention was used to achieve this. This commit also includes two new notifications: reply notifications for when a user replies to another users annotation comment, and mention notifications for when a user is mentioned. If a user is offline/not active on the document when they are mentioned, AEV can be configured to send an email to that user.

Committing on behalf of Martin Rosen (mrosen)

CR: mbrouillette, jnewman

TLDR: Changed Quill Mention to use the OG isNan() function instead of the newer Number.isNan