search

tsgrp / OpenAnnotate

TSG's Browser-based Annotation Tool
8 stars 4 forks source link

Saving a New Annotation with No Comment Fails in IE11 #922

Closed newmanju closed 3 years ago

newmanju commented 3 years ago

Steps to reproduce:

  1. In IE11, add a new annotation and leave the comment blank
  2. Click save and notice how a confirmation message saying annotations were save never shows up
  3. Add a comment to the annotation and it saves correctly
  4. Even removing the comment now allows it to save correctly

The issue is on line 590 of abstractcontroller because the innerhtml property does not exist on an undefined object. This means that either Document or the Document.body is undefined in that context for a new annotation with no comment.

newmanju commented 3 years ago

This issue has not been reproducible on other local environments