search

tsgrp / OpenAnnotate

TSG's Browser-based Annotation Tool
8 stars 4 forks source link

Enhance the Way the List of OAUsers is Populated in OC #927

Closed newmanju closed 2 years ago

newmanju commented 3 years ago

Currently, there is a method called getOAUsers in OCLicenseManager.java that returns a map of userName -> displayName. It contains logic to return a subset of users in the case that a strict license is being use to limit who has access to OA. The issue with this is that the sets it populated in OCLicenseManager.java only run once when the license is first loaded in. So if a new user is added to the implemented backend repository (like Alfresco), that new user will not be included in this list and will not be mentionable in AEV if the configuration is set to allowing mentioning all oa users.

We could potentially take use of an endpoint that can be hit to initiate license re-load while the application is running (need more research)

While we are doing this, we should also try to move the getOAUsers logic out of OCLicenseManager.java and into the AbstractUserImpl

gsteimer commented 2 years ago

Moved to Jira: https://alfresco.atlassian.net/browse/SEP-85