search

tsgrp / OpenAnnotate

TSG's Browser-based Annotation Tool
8 stars 4 forks source link

OAV Mute/Unmute Functionality is Flipped #932

Closed engerernoah closed 2 years ago

engerernoah commented 2 years ago

In OAV the functionality for mute and unmute is flipped, when video sound is playing, hovering over the volume control shows "Unmute" when video sound is not playing hovering over the volume control shows "Mute". These should be flipped to reflect the action that will occur if the volume control is clicked. See gif below: 0gXKdFS56h

engerernoah commented 2 years ago

Fixed with OAV git commit https://git.tsgrp.com/tsgrp/openannotate-video/-/commit/1ff9fe36456d9624b94c02c14e0adec6c560fea4

OAV Mute/Unmute Functionality is Flipped - the tooltip localizations in the video toolbar's html were flipped showing unmute when the video had sound and mute when it did not. Update swaps the tooltips in the html so they properly display in the application. CR: mbrouillette, abrown