tsgrp / OpenAnnotate

TSG's Browser-based Annotation Tool
8 stars 4 forks source link

Toolbar not loading when loading AEV via ACA #934

Closed renesaladrigas closed 2 years ago

renesaladrigas commented 2 years ago

In some cases, and sometimes quite frequently, the AEV toolbar fails to load, leaving the user with an instance of AEV that will not do anything more than display the document. Below is a screen recording of the issue. aev_toolbar_not_loading

A few more details about the issue:

REVISION: A deeper dive into the issue actually shows that this is directly related to the loading of modules in AEV. The toolbar styling refresh update could be the cause of this as now the toolbar has a different dependency set that could be causing it to run before all actions get registered against the ActionRegistry. Given that actions are soft dependencies - toolbar doesn't depend on actions via the require framework - and they are loaded/registered via javascript it becomes really hard to ensure that actions are registered before the toolbarView is loading. Fixing this should probably introduce some sort of event into the ActionRegistry that alerts when all actions are done loading/processed/evaluated, as defined in the toolbar configuration in the AEV properties file in the tomcat, exposed via the OAConfig in the webapp.

gsteimer commented 2 years ago

@renesaladrigas - can this be reproduced in ACA on QA2? If not, then this likely should be 3.5 WIP since the official release of ACA 3.4.4 has the older version of the AEV toolbar.

gsteimer commented 2 years ago

Moved to Jira: https://alfresco.atlassian.net/browse/SEP-88