search

tsgrp / OpenContent

TSG's Web Services for ECM Repositories
8 stars 4 forks source link

Remove /config directories in favor of /classes #55

Open dgrumieaux opened 9 years ago

dgrumieaux commented 9 years ago

In some Alfresco based modules of OpenContent, we use a /config directory to include files on the Alfresco classpath. This can be confusing since the build puts any files in the /config AND /classes directory into the same deployment location, making the two folders redundant.

This enhancement will involve moving any folders and files within /config folders into their corresponding /classes folders, then deleting the /config folders. Additionally, Gradle build should be updated to remove any /config folder logic.

gsteimer commented 9 years ago

@cmlewis - were you in favor of doing the exact opposite here? Basically, remove /classes in favor of /config?

cmlewis commented 9 years ago

The folder structure the alfresco-mmt.jar (which is used to install amps in our old ant builds, current gradle builds, the manual install, etc.) is that the files are in the config folder. We manually copy everything from classes into config in the end. So I'd recommend using config. This might help with the uninstalling of amps as well.

dgrumieaux commented 9 years ago

This is a place where our Alfresco and Dctm builds directly do the opposite, since the OpenContent.war uses a /classes folder. I think this will be confusing either way... I don't want to be in a situation where the Alfresco modules use /config but the core and Dctm modules use /classes.

On Wed, Mar 11, 2015 at 1:29 PM, Christy Lewis notifications@github.com wrote:

The folder structure the alfresco-mmt.jar (which is used to install amps in our old ant builds, current gradle builds, the manual install, etc.) is that the files are in the config folder. We manually copy everything from classes into config in the end. So I'd recommend using config.

— Reply to this email directly or view it on GitHub https://github.com/tsgrp/OpenContent/issues/55#issuecomment-78340314.

cmlewis commented 9 years ago

I don't think it would be too confusing. As long as we get everything into the config folder, it would be easy enough to let the developers know. I can make the build work either way. @gsteimer @benallenallen Thoughts?

gsteimer commented 9 years ago

I'm fine either way, but hopefully making OC a true subsystem will render this moot.

cmlewis commented 9 years ago

I prefer we follow Alfresco best practices for the mmt jar and use config.