search

tsgrp / OpenContent

TSG's Web Services for ECM Repositories
8 stars 4 forks source link

Wizard Forms and Hot Docs: different implementations for parsing Wizard forms #71

Open mikeblum opened 8 years ago

mikeblum commented 8 years ago

Is there a reason we have separate implementations for parsing display values from a Wizard form in '''WordTemplatingUtil''' as well as PSIJSONUtil? As far as I can tell, the Word Docs impl needs a map of short-label -> display value. Currently the implementation for PSIJSONUtil.indexQuestionsAndAnswers creates a string (comma-seperated for repeating values). There appears to be an issue with pre-filled select-box answers and the Word Docs impl. Can we standardize on the PSIJSONUtil.indexQuestionsAndAnswers call, as it doesn't look like the type is really needed and create the Word Doc pojos from the map of questions and answers?

@zkeller - comments?

gsteimer commented 8 years ago

I'd say all JSON parsing logic for PSIs should be in PSIJSONUtil. Any duplicated code in WordTemplatingUtil should be removed.