search

tshaddix / webext-redux

A set of utilities for building Redux applications in Web Extensions.
MIT License
1.22k stars 180 forks source link

Wrap Store throwing error. "No matching Signature" #212

Closed jbarzegar closed 5 years ago

jbarzegar commented 5 years ago

Hi there!

My team recently updated webext-redux to 2.1.1 and noticed an error was being thrown as soon as you'd wrap the store.

wrapStore.js:196 Uncaught (in promise) TypeError: Error in invocation of tabs.query(object queryInfo, function callback): No matching signature.
    at _default (wrapStore.js:196)

Digging through wrapStore it seemed like it was related to the third argument below https://github.com/tshaddix/webext-redux/blob/master/src/wrap-store/wrapStore.js#L170

The error itself doesn't seem to be actively breaking anything. But was kind of a surprise

tshaddix commented 5 years ago

Yikes! Thanks for letting me know. Not sure how that slipped through the cracks. I must have removed that argument after the smoke test to pass eslint rules.

I'll pass something over right now.

jbarzegar commented 5 years ago

Thanks @tshaddix ! Really appreciate your quick response

tshaddix commented 5 years ago

Should be fixed in 2.1.2! Give me one sec to publish. No problem - completely my bad. I'm embarrassed that it happened.

tshaddix commented 5 years ago

Done!