Type definitions conflict with the latest version of redux

tshaddix / webext-redux

A set of utilities for building Redux applications in Web Extensions.

MIT License

1.23k stars 180 forks source link

Type definitions conflict with the latest version of redux #221

Closed RobertB4 closed 4 years ago

RobertB4 commented 5 years ago

Redux now has an observable as part of the store. https://github.com/reduxjs/redux/blob/8aca937f695997e979bf8c0e03dbf22a2bf284dc/index.d.ts#L247

I "fixed" it by creating a custom .d.ts file, copy pasted the type definition file of webext-redux and added the observable to the store class for now to silence the compiler, though I guess eventually this has to be fixed on the library level.

tshaddix commented 4 years ago

@RobertB4 Thanks for reporting. Could you open a pull request and add your changes to this libraries TS definitions? It would be very appreciated!

tshaddix commented 4 years ago

Resolved in #236