store crashes if a webpage has an id="global" element on it

tshaddix / webext-redux

A set of utilities for building Redux applications in Web Extensions.

MIT License

1.22k stars 179 forks source link

Closed mavalos1 closed 4 years ago

mavalos1 commented 4 years ago

If a page has an element that has id="global" like this:

A div with Id global

it will result in util.js breaking the store at checking for global.chrome and/or browser. image-2020-05-25-08-31-42-553

tshaddix commented 4 years ago

Interesting. It seems like we could just swap global for window to fix this. Thanks for submitting a ticket.