tshaddix / webext-redux

A set of utilities for building Redux applications in Web Extensions.
MIT License
1.23k stars 180 forks source link

wrapStore tabs.query has extra argument #275

Open alexelisenko opened 3 years ago

alexelisenko commented 3 years ago

I am seeing an error when running in chrome:

Uncaught (in promise) Error: Expected at most 1 argument for query(), got 2. It looks like this line here:

https://github.com/tshaddix/webext-redux/blob/master/src/wrap-store/wrapStore.js#L166

it's trying to supply a callback function, but browser.tabs.query does not take any callback parameters and instead returns a promise.

I think that call to tabs.query needs to use .then() instead, unless I'm missing something?

https://developer.mozilla.org/en-US/docs/Mozilla/Add-ons/WebExtensions/API/tabs/query