bind 'this' for getState and subscribe in Store constructor

tshaddix / webext-redux

A set of utilities for building Redux applications in Web Extensions.

MIT License

1.22k stars 179 forks source link

bind 'this' for getState and subscribe in Store constructor #289

Closed dermeck closed 1 month ago

dermeck commented 1 year ago

This change adds 'this'-binding inside the Store constructor for getState and subscribe. This fixes the Uncaught TypeError: Cannot read properties of undefined (reading 'state') when using webext-redux with newer versions of react-redux.

Should fix https://github.com/tshaddix/webext-redux/issues/280 and fix https://github.com/tshaddix/webext-redux/issues/286

buberdds commented 1 year ago

Is there a chance to merge this fix?