Open 0x5c opened 6 years ago
sure, this wouldn't be too difficult, where would you want to set who's on the whitelist? directly in the code or through the heroku env variables? and how would you like to set the user? by user ID or user name (my vote would be for user id but then it's a little harder to locate)?
For our use, IDs shouldn't be a problem as there wouldn't be a lot of "special users",although I can't speak for others who may want to use that feature.
Would it be possible to make a whitelist per protected channel? If yes, I think that either code/env, as long as it can take JSON input, would be good.
On a completely unrelated note, there is a relatively frequent disconnection bug that seems to emanate from botkit. I'll file a proper bug report once I manage to get on my computer and gather logs/relevant info.
Kk, this is good direction. I’ve been wanting to rewrite everything using async/await and really clean up the code so I’ll look into getting around to that some time later this week. If all goes according to plan hopefully I’ll have something later this week.
On Mon, Feb 5, 2018 at 10:33 PM 0x5c notifications@github.com wrote:
For our use, IDs shouldn't be a problem as there wouldn't be a lot of "special users",although I can't speak for others who may want to use that feature.
Would it be possible to make a whitelist per protected channel? If yes, I think that either code/env, as long as it can take JSON input, would be good.
On a completely unrelated note, there is a relatively frequent disconnection bug that seems to emanate from botkit. I'll file a proper bug report once I manage to get on my computer and gather logs/relevant info.
— You are receiving this because you commented.
Reply to this email directly, view it on GitHub https://github.com/tshamz/brianwilliams/issues/1#issuecomment-363324867, or mute the thread https://github.com/notifications/unsubscribe-auth/AB-qQI9cIxuv47yqXGDz9_mTftJ4en6Rks5tR_IwgaJpZM4QsjVt .
--
www.tylershambora.com http://www.tylershambora.com/
Neat!
alright, i updated everything to now use, amongst other things:
the flow looks like this:
I still have a little more work to do:
if you want take what i have right now and just finish it up on your own, you can find it in the #update-to-new-botkit-and-node branch.
i'll update you when everything is finished. enjoy!
oooooooo, i almost forgot, everything works a little differently now so the whole config has been changed. When i get some more free time on my hands i'll get around to updating the readme.
Woooaaaaaaa! It's amazing!
Basically allowing whitelisted users to directly post on a r-o channel.