search

tshatrov / ichiran

Linguistic tools for texts in Japanese language
MIT License
299 stars 33 forks source link

More portable version using SQLite #18

Open tslater opened 2 years ago

tslater commented 2 years ago

I'm curious if the maintainers would have any interest in a conversion from Postgresql to SQLite. The idea would be to Ichiran much more operationally simple, allowing it to be integrated into developer workflows more easily. Rather than needing a separate db process and configuration parameters, Sqlite could integrate much more seamlessly.

tshatrov commented 2 years ago

Well, the main problem is that the postmodern library which is used to access the database only supports Postgres, and it also happens to be the best db library, and Postgres is more 'web scale' for my purposes. I understand how Sqlite might be better for certain usecases, but it might be quite hard to support it.

tslater commented 2 years ago

Would you potentially accept a PR that made it possible to use either?

On Wed, Dec 22, 2021 at 1:02 PM tshatrov @.***> wrote:

Well, the main problem is that the postmodern library https://github.com/marijnh/Postmodern which is used to access the database only supports Postgres, and it also happens to be the best db library, and Postgres is more 'web scale' for my purposes. I understand how Sqlite might be better for certain usecases, but it might be quite hard to support it.

— Reply to this email directly, view it on GitHub https://github.com/tshatrov/ichiran/issues/18#issuecomment-999830890, or unsubscribe https://github.com/notifications/unsubscribe-auth/AADNWLXKO6IJ2PRTRA7XRMTUSIVGZANCNFSM5KTEV2NA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

tshatrov commented 2 years ago

Hm, I don't know, depends on how "invasive" it is to the existing codebase. Also it might make adding new features more difficult as I'd have to test if each query works on both databases. But I'd be definitely curious to see such a PR.

tslater commented 2 years ago

Ok, I'll let you know if I get around to it. Thanks for letting me know!