search

tsherwen / AC_tools

Module for working with global/regional Chemical Transport Model (CTM) output and observations
MIT License
13 stars 10 forks source link

Issue with ticks in difference map plot #74

Closed BenNewsome closed 5 years ago

BenNewsome commented 7 years ago

Not enough ticks and not evenly spaced.

image

BenNewsome commented 7 years ago

Tests should be made to make sure the colorbar function can work for a range of inputs.

BenNewsome commented 7 years ago

@tsherwen in funcs4plotting.py:388 What is buffer space in fixcb_buffered, and how does it differ from fixcb ?

tsherwen commented 7 years ago

This is a buffered version of the colorbar to allow for the higest tick value to appear.

from (the latest version of) map_plot:

fixcb_buffered (array): minimium and maximum to fix colourbar, with buffer space

On 21 November 2016 at 14:33, Ben Newsome notifications@github.com wrote:

@tsherwen https://github.com/tsherwen in funcs4plotting.py:388 What is buffer space in fixcb_buffered, and how does it differ from fixcb ?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/tsherwen/AC_tools/issues/74#issuecomment-261953836, or mute the thread https://github.com/notifications/unsubscribe-auth/AEeGjDZ_B1Mr0pIfvgkQYgA0BPSCD90Vks5rAavVgaJpZM4K4PEN .

Dr Tomás Sherwen Postdoctoral Research Associate

Wolfson Atmospheric Chemistry Laboratories (WACL) Department of Chemistry, University of York Heslington, York, YO10 5DD Office phone (shared): +44(0)1904 324758 Homepage: https://www.york.ac.uk/chemistry/staff/resstaff/sherwent/ tomas.sherwen@york.ac.uk [image: tomas.sherwen] http://orcid.org/0000-0002-3006-3876 https://scholar.google.co.uk/citations?user=e3SmNJoAAAAJ&hl

BenNewsome commented 7 years ago

buffered means that it includes the maximum and minumum values given from the range.

Plotting between 10 and 0 would only have [2,4,6,8] so adding 1% to min and max gives desired [0,2,4,6,8,10].

This might be solvable within the function and could be removed from the inputs ideally.

tsherwen commented 7 years ago

Please could you email me a link to the data/and the code. What is the range the colourbar is trying to present? is it set to log or linear?

BenNewsome commented 7 years ago

It is now fixed. It was an update you did that missed out a "if not". Fixed now after your push this afternoon.

On Mon, 21 Nov 2016, 19:39 tsherwen, notifications@github.com wrote:

Please could you email me a link to the data/and the code. What is the range the colourbar is trying to present? is it set to log or linear?

— You are receiving this because you were assigned. Reply to this email directly, view it on GitHub https://github.com/tsherwen/AC_tools/issues/74#issuecomment-262044071, or mute the thread https://github.com/notifications/unsubscribe-auth/AGbYJr1MI7c_6Gwlcj4ETVJLS6SlrAeLks5rAfNVgaJpZM4K4PEN .