tshort / StaticCompiler.jl

Compiles Julia code to a standalone library (experimental)
Other
488 stars 31 forks source link

Major cleanup. Remove `compile`, `compile_wasm`, and `MixTape` #146

Closed MasonProtter closed 7 months ago

MasonProtter commented 7 months ago

This removes the compile functionality (closes https://github.com/tshort/StaticCompiler.jl/issues/119), and does some general cleanup and fixes.

Before we merge this though, I'd also like to also discuss removing

MasonProtter commented 7 months ago

Failing integration tests appear to be because of wasm.

tshort commented 7 months ago

Thumbs up on this PR. I looked over the code, but I didn't really do a code review. If it passes tests, I'm good.

I'm okay with removing both the Mixtape and the wasm support. For wasm, I think WebAssemblyCompiler will (should) compile more code and offer more capability. I agree that the @device_override is way easier than Mixtape. For code I'm using (mainly WebAssemblyCompiler), I've used the overlays a lot but haven't needed Mixtape.

tshort commented 7 months ago

As part of the cutting of features, I would like to keep the cross-compiling support.

MasonProtter commented 7 months ago

Okay, I've removed the wasm stuff, and the mixtape stuff. I also added an ability to specify your own method_table during compilation, in case there are cases where someone wants to do a certain overload just for a certain function they want to compile, but don't want to pollute the StaticCompiler wider method-table.

brenhinkeller commented 7 months ago

Hooray!