Closed aminya closed 4 years ago
Looks good to me. I'll plan on merging this weekend. It's interesting to see the latest on Julia package docs and other features. Thanks for the directions, too.
Looks good to me. I'll plan on merging this weekend. It's interesting to see the latest on Julia package docs and other features. Thanks for the directions, too.
You're welcome!
P.S: you can remove Travis and Appveyor toml files too and only use Github Actions (which is faster and better IMO). You can remove their apps from the repository too.
Merging #21 into master will decrease coverage by
0.22%
. The diff coverage is0%
.
@@ Coverage Diff @@
## master #21 +/- ##
==========================================
- Coverage 91.11% 90.88% -0.23%
==========================================
Files 12 12
Lines 439 450 +11
==========================================
+ Hits 400 409 +9
- Misses 39 41 +2
Impacted Files | Coverage Δ | |
---|---|---|
src/helpers/helpers.jl | 75% <0%> (-8.34%) |
:arrow_down: |
src/helpers/juliaconfig.jl | 88.88% <0%> (-2.42%) |
:arrow_down: |
src/helpers/standalone-exe.jl | 94.73% <0%> (+0.79%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 51a2240...50a30c2. Read the comment docs.
Okay, this PR is merged, and I added the public and private keys. Does something else need to be done to trigger docs?
Ahh, I just forgot that StaticCompiler is not registered yet. The run here fails to add StaticCompiler. https://github.com/tshort/StaticCompiler.jl/runs/448105083?check_suite_focus=true#step:4:11
1) we can register StaticCompiler and fix the error 2) I can add a line to add StaticCompiler based on the link.
I will 2 for now until you register.
To make automatic deployment work:
Add the public key to https://github.com/tshort/StaticCompiler.jl/settings/keys Add the private key to https://github.com/tshort/StaticCompiler.jl/settings/secrets