search

tshort / StaticCompiler.jl

Compiles Julia code to a standalone library (experimental)
Other
489 stars 31 forks source link

Support for errors #85

Closed gbaraldi closed 1 year ago

gbaraldi commented 1 year ago

This copies the method overlays from CUDA.jl. It doesn't work currently but I believe it's a nice start.

brenhinkeller commented 1 year ago

Awesome! I'll try to dig in and see how it goes!

brenhinkeller commented 1 year ago

See PR against your fork @gbaraldi for a fix for most of the crossed wires with the compile interface -- if you merge that I think it should propagate here.

Then there's just something that's causing dynamic dispatch / allocations that didn't used to be there in some of the compiled methods in the integration tests...

brenhinkeller commented 1 year ago

If we can figure that out, then we just need to add some tests that test the new errors!

MasonProtter commented 1 year ago

Why was this merged with all tests failing?

brenhinkeller commented 1 year ago

The github web UI somehow did that for me when I was trying to merge the fixes from PR #86 into this one to resolve conflicts... trying to revert now!

brenhinkeller commented 1 year ago

Ok, reverted in https://github.com/tshort/StaticCompiler.jl/commit/5e4f03febc5b8a816ef24a13c5a72019133f7a79, but looks like I can't just reopen the PR so @gbaraldi if you don't mind re-PRing from your fork... sorry for the mixup!

brenhinkeller commented 1 year ago

For anyone following this: reopened as #90