tshort / dactyl-keyboard

Dactyl-ManuForm, a parameterized ergonomic keyboard
GNU Affero General Public License v3.0
1.19k stars 189 forks source link

Added some options. #29

Closed ibnuda closed 4 years ago

ibnuda commented 5 years ago

Hello, Mr. Short.

I've added some options to the codebase.

  1. whether to use wire guide or not.
  2. whether to use side nub or not. this relates to kailh switches compat.
  3. whether to butcher two outer thumb keys or not.
  4. whether to use trrs hole instead of rj9.
  5. whether to use promicro usb connection instead of teensy holder.
tshort commented 4 years ago

All these improvements are great. I'm not sure what to do with them, though. This is not like normal open-source code where I can test it out. I don't plan on building another model soon.

The main option I can think of is:

Any other ideas?

Pinging @SeattleChris as he's had some recent PR's, too.

SeattleChris commented 4 years ago

Regarding the side nub:

I'm brand new to 3D-printing and making mechanical keyboards. So far I have only been doing low-resolution/quality quick prints to test out some odd angles for the thumb section. I have a batch of test switches of different brands and I have found that, while a couple fit okay, most of them don't seem to fit correctly with the side nub for what I've done so far. Many of the key-switches will fit when rotated 90 degrees. This has been fine for my testing but is not a solution for final prints.

At first, I thought the misfit was due to the low-quality test prints, but as I look into it more I suspect the design is flawed for all but a few key-switch brands and/or models. It seems to me that it would be good for the repository to have options. Or at least, I would like to try out some other options for the key-switch hole.