search

tsibelman / aws-signer-v4-dot-net

Sign HttpRequestMessage using AWS Signature v4 using request information and credentials.
Apache License 2.0
72 stars 27 forks source link

Strong-name assembly #14

Closed FantasticFiasco closed 5 years ago

FantasticFiasco commented 5 years ago

Closes #12

tsibelman commented 5 years ago

Thank you for the PR but I need the actual key to sign the dll and github is not a good place to pass such items, so I generated it on my own

FantasticFiasco commented 5 years ago

Thanks for merging this!

github is not a good place to pass such items

If you would use the key for security you are correct, but we aren't. We are using strong-naming mainly to prevent version conflicts. The guidance from Microsoft says:

CONSIDER adding the strong naming key to your source control system. A publicly available key lets developers modify and recompile your library source code with the same key.

tsibelman commented 5 years ago

Ok I adding it to source then