search

tsibelman / aws-signer-v4-dot-net

Sign HttpRequestMessage using AWS Signature v4 using request information and credentials.
Apache License 2.0
72 stars 27 forks source link

Update AWS4RequestSigner.cs #29

Closed branch-slalom closed 3 years ago

branch-slalom commented 3 years ago

Use StringComparer.OrdinalIgnoreCase when sorting query params

To add some more detail, query params need to be sorted by their "character code point".

Sort the parameter names by character code point in ascending order.

https://docs.aws.amazon.com/general/latest/gr/sigv4-create-canonical-request.html

The internal AWS4Signer also uses the OrdinalIgnoreCase

https://github.com/aws/aws-sdk-net/blob/master/sdk/src/Core/Amazon.Runtime/Internal/Auth/AWS4Signer.cs#L843-L850

tsibelman commented 3 years ago

Please update version number as well.

branch-slalom commented 3 years ago

@tsibelman Updated the version number in the csproj. Thanks for the quick response!

branch-slalom commented 3 years ago

@tsibelman Have you had a chance to look at the changes? Was hoping to have this merged sooner rather than later

tsibelman commented 3 years ago

Hi published the nuget

branch-slalom commented 3 years ago

Hi published the nuget

Thanks!