search

tsibelman / aws-signer-v4-dot-net

Sign HttpRequestMessage using AWS Signature v4 using request information and credentials.
Apache License 2.0
72 stars 27 forks source link

Suggestion #7

Closed jwiater closed 5 years ago

jwiater commented 5 years ago

I recommend escaping the querystring[key] in your GetCanonicalQueryParams method like:

var queryParams = keys.Select( key => $"{key}={Uri.EscapeDataString( querystring[key] )}" );

This will help avoiding problems with some character encoding like space which can be + or %20. This has caused issues in my case

tsibelman commented 5 years ago

Thank you I published 0.4.0 version