search

tsiemens / pathfinder-toolkit

A Pathfinder RPG Android app, for managing characters and parties
22 stars 6 forks source link

Combat stats scrolls to the right when editing #32

Closed tsiemens closed 10 years ago

tsiemens commented 10 years ago

When in the combat stats fragment, the horizontally scrolling areas will scroll all the way to the right whenever an EditText takes focus, or an edit is made in one of the EditTexts.

They should not scroll unless intentionally done by the user.

tsiemens commented 10 years ago

This appears to be another issue with edit texts and scrolling (as we encountered with fluff fragment). I don't really want to deal with the complexity of the framework here, so I'm going to use a work around, I think.

I think the best solution might be to have a similar interface to the ability selection, but have a simple dialog + edit text pop up (like in fluff). This would also unify the look and feel of those rows a bit more.

tsiemens commented 10 years ago

@gnarph you'll be happy to know that I'm refactoring/rewriting the combat stats fragment while I'm on this task. Hopefully it will be less of a clusterf*\ afterwards.

Edit: Woo! Chopped out at least 600 lines of code. That class is much less tedious, and much more interesting to read now. Still somewhat complicated, but not as impossible. Modifications should also be simpler to make now. The xml file is also about 1/3 the length now as well.