search

tsightler / ring-mqtt

Ring devices to MQTT Bridge
MIT License
569 stars 103 forks source link

Added support for arming delay when using Home mode #651

Closed amura11 closed 1 year ago

amura11 commented 1 year ago

Modifed the code for handling the exit delay to work for both Away and Home modes (all/some modes)

tsightler commented 1 year ago

Thanks, I didn't even know it was possible to have an exit delay for home mode. Thanks for catching the typos as well!

tsightler commented 1 year ago

I'm going to close this as I'm probably going to implement a different method for exit delay altogether, but thanks for letting me know that exit delay was possible with home mode. I'll make sure the new implementation works with both home and away modes.

tsightler commented 1 year ago

Just FYI, the development branch now contains to new implementation of exit delay. This should work for both home and away modes and includes an exitSecondsLeft and targetState attribute so you can, for example, have different automations during exit delay based on whether the final state will be home or away. With the previous implementation it would not have been possible to tell the difference.

If you get a chance, feel free to test it out and provide feedback. Thanks again for the contribution, even though I didn't merge your specific PR I will still credit you with the inspiration for the new implementation.