search

tsightler / ring-mqtt

Ring devices to MQTT Bridge
MIT License
569 stars 103 forks source link

Connect status #678

Closed WoCha-FR closed 1 year ago

WoCha-FR commented 1 year ago

Hi, This pull request permit to monitor online / offline status of polled devices (camera, chime, intercom). in reference with issue #674 Have a good day.

tsightler commented 1 year ago

Hi, thanks for the PR but I don't believe this implementation is something that I would merge. For one thing, if you just want another topic it should be an entity, not another device level topic. Probably it could just be another property of the info sensor.

However, I'd say that none of that is technically what should be done. When I first added online/offline status the original plan was to have it report actual online/offline status of the device, not the connectivity status that it currently does.

So realistically, the proper thing to do would be to implement proper device-level online/offline status for all devices on the current availability topic, and not just for polled devices, then have additional status for connectivity between ring-mqtt to Ring API, and perhaps an overall ring-mqtt status implement with birth/last-will so it would be possible to know if ring-mqtt itself was running.

However, as in the past 5 years nobody has really seemed to care and, to be honest, I've never seen a single one of my cameras go offline in 5 years (OK, not really true, one was damaged by a lightning strike, but still that was easy to know), I just never got around it. I appreciate that it is clearly important enough to you to submit this PR, but I'm just not interesting in it for now. I will keep it on the backlog and maybe look to implement a proper online/offline status in a future version.