tsightler / ring-mqtt

Ring devices to MQTT Bridge
MIT License
569 stars 103 forks source link

Publish Transition Delay Tiemout #696

Closed amura11 closed 1 year ago

amura11 commented 1 year ago

Added code to push the transition delay as an attribute of the alarmInfo sensor

tsightler commented 1 year ago

Thanks for the contribution.

Please describe the use case. Also, this should be an attribute of the alarm control panel entity, not the device level info sensor. The alarm control panel entity already includes attributes with live entry/exit seconds remaining so I'm struggling a little bit as to the benefit of having the expire time.

amura11 commented 1 year ago

I was working off a really old version of the plugin before those were added (and I didn't notice the additions when I merged the new commits) so my additions are completely pointless. Oops 🤦‍♂️