search

tsightler / ring-mqtt

Ring devices to MQTT Bridge
MIT License
600 stars 106 forks source link

Fixed bug that incorrectly set location mode to 'disarmed'. Caused by… #899

Closed wahflz closed 1 month ago

wahflz commented 2 months ago

I ran into a bug that repeatedly published the Location Mode as 'disarmed'. I'm not familiar with node or JavaScript, but I believe this was caused by an async function not being awaited.

I'm not familiar with the rest of the code base , so I don't know if this will make any breaking changes.

Sorry for any confusion, I'm new to this. I hope this pull request works properly 🤞.

tsightler commented 1 month ago

Sorry for the delay, thanks for the PR. I have an alarm so modes works differently in that case thus little things like this can easily slip through testing for pure "modes" users. The change looks correct so I'll merge it as part of 5.7.2! Really appreciated